Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): support vitest 3 #29908

Merged
merged 1 commit into from
Feb 7, 2025
Merged

feat(testing): support vitest 3 #29908

merged 1 commit into from
Feb 7, 2025

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 6, 2025

Current Behavior

We currently still generate Vitest configuration using Vitest v1.

Vitest v3 has released so Nx is pretty far behind now.

Expected Behavior

Update vitest version to v3 and use it to configure new projects.
Existing workspaces using v1 will continue to use v1.

@Coly010 Coly010 requested review from a team as code owners February 6, 2025 11:50
@Coly010 Coly010 self-assigned this Feb 6, 2025
@Coly010 Coly010 requested a review from a team as a code owner February 6, 2025 11:50
@Coly010 Coly010 requested a review from ndcunningham February 6, 2025 11:50
Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 7, 2025 3:06pm

@Coly010 Coly010 requested a review from leosvelperez February 6, 2025 11:50
Copy link

nx-cloud bot commented Feb 6, 2025

View your CI Pipeline Execution ↗ for commit 9048327.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 36m 30s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 19s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 11s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 9s View ↗
nx documentation ✅ Succeeded 2m 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-07 15:42:18 UTC

@jaysoo jaysoo merged commit a7c8c10 into master Feb 7, 2025
12 checks passed
@jaysoo jaysoo deleted the vitest/support-v3 branch February 7, 2025 18:10
isaacplmann pushed a commit that referenced this pull request Feb 11, 2025
We currently still generate Vitest configuration using Vitest v1.

Vitest v3 has released so Nx is pretty far behind now.

Update vitest version to v3 and use it to configure new projects.
Existing workspaces using v1 will continue to use v1.
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants