Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linter): produce type information for the eslint-plugin main entry point #29855

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix(linter): produce type information for the eslint-plugin main entry point #29855

merged 1 commit into from
Feb 4, 2025

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Feb 3, 2025 •
edited
Loading

Current Behavior

The @nx/eslint-plugin main entry point is untyped.

Expected Behavior

The @nx/eslint-plugin main entry point should provide types.

Related Issue(s)

Fixes #28448
Fixes #29816

@leosvelperez leosvelperez self-assigned this Feb 3, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Feb 3, 2025 5:01pm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 3, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 2654e35.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 19m 23s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-03 17:57:08 UTC

@leosvelperez leosvelperez marked this pull request as ready for review February 3, 2025 17:33
@leosvelperez leosvelperez requested a review from a team as a code owner February 3, 2025 17:33
@jaysoo jaysoo merged commit 1fbcd73 into master Feb 4, 2025
12 checks passed
@jaysoo jaysoo deleted the eslint/fix-entry-point-types branch February 4, 2025 14:15
FrozenPandaz pushed a commit that referenced this pull request Feb 6, 2025
@leosvelperez @FrozenPandaz
fix(linter): produce type information for the eslint-plugin main entr…
e248a94 
…y point (#29855)

## Current Behavior

The `@nx/eslint-plugin` main entry point is untyped.

## Expected Behavior

The `@nx/eslint-plugin` main entry point should provide types.

## Related Issue(s)

Fixes #28448
Fixes #29816

(cherry picked from commit 1fbcd73)
FrozenPandaz pushed a commit that referenced this pull request Feb 6, 2025
@leosvelperez @FrozenPandaz
fix(linter): produce type information for the eslint-plugin main entr…
7eda58e 
…y point (#29855)

## Current Behavior

The `@nx/eslint-plugin` main entry point is untyped.

## Expected Behavior

The `@nx/eslint-plugin` main entry point should provide types.

## Related Issue(s)

Fixes #28448
Fixes #29816

(cherry picked from commit 1fbcd73)
@github-actions GitHub Actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaysoo jaysoo jaysoo approved these changes

@meeroslav meeroslav Awaiting requested review from meeroslav meeroslav is a code owner automatically assigned from nrwl/nx-linter-reviewers

Assignees

@leosvelperez leosvelperez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing types for main entry point of @nx/eslint-plugin @nx/eslint-plugin doesn't export types of configs.
2 participants
@leosvelperez @jaysoo