Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): transpile SVGR into React 19 compatible component #29543

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jan 7, 2025

This PR fixes an issue with React 19 and our @nx/react/plugins/jest transform. The current transform uses an unsupported $$typeof symbol, and also uses the deprecated forwardRef API.

The updated transform will use new API for React 19 and older, while maintaining the previous API for React 18 and earlier. The backwards compatibility may be needed if the test is using ref, which requires forwardRef older versions.

Current Behavior

SVGR fails in Jest tests with React 19

Expected Behavior

SVGR works

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner January 7, 2025 21:34
@jaysoo jaysoo requested a review from ndcunningham January 7, 2025 21:34
Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Jan 7, 2025 9:34pm

Copy link

nx-cloud bot commented Jan 7, 2025

View your CI Pipeline Execution ↗ for commit 63562d6.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 28m 21s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=3f3c8... ✅ Succeeded 18s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 17s View ↗
nx documentation --no-dte ✅ Succeeded 41s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-07 21:56:36 UTC

@jaysoo jaysoo merged commit 90c0c8e into master Jan 7, 2025
6 checks passed
@jaysoo jaysoo deleted the fix/react-jest-svgr branch January 7, 2025 23:26
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants