fix(core): exponential retry on cache put fail #29017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix exponential retries so that it behaves according to the comments. The current comments and implementation of this exponential backoff are not behaving correctly, causing issues when many (~100) parallel tasks access the same local cache. I've updated it to have the correct functionality while still maintaining the max allowable time.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 517ac95.
☁️ Nx Cloud last updated this comment at |
|
@AgentEnder @Cammisuli Please take a look and give feedback if need be. Thank you 🙏 🙏 |
Cammisuli
approved these changes
Jan 31, 2025
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix exponential retries so that it behaves according to the comments.
The current comments and implementation of this exponential backoff are not behaving correctly, causing issues when many (~100) parallel tasks access the same local cache on a Network Drive. I've updated it to have the correct functionality while maintaining the maximum allowable time.
Current Behavior
The current exponential backoff retry logic only allows up to 1364 ms (4 + 4² + 4³ + 4⁴ + 4⁵), while the comment allows up to 20480 ms, albeit with confusing maths.
Expected Behavior
Exponential backoff retry is run correctly with the maximum allowable time of 20480 ms
Related Issue(s)
#21926
Fixes #21926