Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js): only add typescript project references for explicit dependencies in sync generator #28998

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+34 −0
Open

fix(js): only add typescript project references for explicit dependencies in sync generator #28998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f17b459
fix(js): only add typescript project references for explicit dependen…
cogwirrel Nov 19, 2024
c975d7d
Merge branch 'master' into fix/sync-generator-implicit-deps
cogwirrel Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions packages/js/src/generators/typescript-sync/typescript-sync.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ describe('syncGenerator()', () => {
});
}

function addProjectWithImplicitDependencies(
name: string,
implicitDependencies: string[]
) {
addProject(name);
projectGraph.nodes[name].data.implicitDependencies = implicitDependencies;
}

beforeEach(async () => {
tree = createTreeWithEmptyWorkspace();
projectGraph = {
Expand Down Expand Up @@ -612,6 +620,23 @@ describe('syncGenerator()', () => {
`);
});

it('should not add a reference if dependent project is an implicit dependency', async () => {
addProject('implicit-dep');
addProjectWithImplicitDependencies('foo', ['implicit-dep']);

await syncGenerator(tree);

expect(tree.read('packages/foo/tsconfig.json').toString('utf-8'))
.toMatchInlineSnapshot(`
"{
"compilerOptions": {
"composite": true
}
}
"
`);
});

describe('without custom sync generator options', () => {
it.each`
runtimeTsConfigFileName
Expand Down
9 changes: 9 additions & 0 deletions packages/js/src/generators/typescript-sync/typescript-sync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,13 +465,22 @@ function collectProjectDependencies(

collectedDependencies.set(projectName, []);

const implicitDependencies = new Set(
projectGraph.nodes[projectName].data.implicitDependencies ?? []
);

for (const dep of projectGraph.dependencies[projectName]) {
const targetProjectNode = projectGraph.nodes[dep.target];
if (!targetProjectNode) {
// It's an npm dependency
continue;
}

if (implicitDependencies.has(targetProjectNode.name)) {
// It's an implicit dependency and therefore not explicitly referenced in code
continue;
}

// Add the target project node to the list of dependencies for the current project
if (
!collectedDependencies
Expand Down