chore(rspack): update resource query to reduce confusion #28967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ac4e120. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
Svgr docs use `url` as resourceQuery value, https://react-svgr.com/docs/webpack/#use-svgr-and-asset-svg-in-the-same-project Having resource query match on `react` is confusing because you would want the inverse, treat the url as a resource if it has the query and as a React component otherwise
samtsai
force-pushed
the
fix-resource-query
branch
from
ad12b50 to
ac4e120
Compare
Coly010
approved these changes
Dec 12, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
withReactinrspackadds svg rules to support svgs as assets/urls and React components.Expected Behavior
Svgr docs use
urlas resourceQuery value, https://react-svgr.com/docs/webpack/#use-svgr-and-asset-svg-in-the-same-project Having resource query match onreactis confusing because you would want the inverse, treat the url as a resource if it has the query and as a React component otherwise.