Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(misc): migrate from chalk to picocolors #27967

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Sep 18, 2024

Migrates from chalk to the much smaller and faster picocolors.

Part of a wider ecosystem cleanup, we are moving many projects over to picocolors or node's native styleText.

If you let me know you're happy with this change, I'll push a branch for each of the other packages to do the same.

I will catch up from master when I'm back on my laptop 👍

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Sep 20, 2024 11:10am

@JamesHenry
Copy link
Collaborator

Thanks @43081j this is very similar in nature to the recently merged: #27932

Please can you implement the same feedback I gave on there - add the ESLint rule to this project to catch imports of chalk and give the feedback that picocolors should be used instead

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@JamesHenry
Copy link
Collaborator

JamesHenry commented Sep 18, 2024

This change should really be cleanup, it should be imperceptible to the end user and not fix a bug nor add a feature.

I've updated it to be cleanup(misc) instead of feat(nx-plugin), I am surprised we don't have a commit scope for create-nx-workspace but that's why I went for misc. The nx-plugin one can be used for the nx-plugin project

@JamesHenry JamesHenry changed the title feat(nx-plugin): migrate from chalk to picocolors cleanup(nx-plugin): migrate from chalk to picocolors Sep 18, 2024
@JamesHenry JamesHenry changed the title cleanup(nx-plugin): migrate from chalk to picocolors cleanup(misc): migrate from chalk to picocolors Sep 18, 2024
@43081j
Copy link
Contributor Author

43081j commented Sep 18, 2024

Makes sense to me 👍

Wasn't sure what the correct scope and type of change was. Thanks for the tip

Will resolve the comments soon

@43081j
Copy link
Contributor Author

43081j commented Sep 19, 2024

I'm struggling to understand the current failure

any chance you could help me out? 👀 I think its a failing test but I cant seem to find where in the circleci output we can get hold of which test

@43081j 43081j force-pushed the whiteboards-round-1 branch from f74fd81 to 7300501 Compare September 19, 2024 11:21
@JamesHenry
Copy link
Collaborator

@43081j I believe it was a memory issue, I have fixed up the lock file conflict and pushed

@JamesHenry JamesHenry merged commit 0d37ef9 into nrwl:master Sep 20, 2024
6 checks passed
@JamesHenry
Copy link
Collaborator

JamesHenry commented Sep 20, 2024

Thanks again! I confirmed with a local build that these are visually identical

@43081j 43081j deleted the whiteboards-round-1 branch September 20, 2024 13:12
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants