Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): add module federation static server #27802

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Sep 6, 2024

Current Behavior

We can serve each application in a module federation setup statically, but only individually.

Expected Behavior

Add a serve static executor for module federation hosts which will also spin up the remotes statically

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from jaysoo September 6, 2024 12:03
Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 3:50pm

@Coly010 Coly010 self-assigned this Sep 6, 2024
@Coly010 Coly010 force-pushed the module-federation-static-server branch from a177d0b to 13c7f8a Compare September 9, 2024 10:08
@Coly010 Coly010 force-pushed the module-federation-static-server branch from 13c7f8a to 55c8143 Compare September 9, 2024 12:30
@Coly010 Coly010 marked this pull request as ready for review September 9, 2024 14:54
@Coly010 Coly010 requested review from FrozenPandaz, AgentEnder and a team as code owners September 9, 2024 14:54
@Coly010 Coly010 force-pushed the module-federation-static-server branch from b3aad74 to 5a4250f Compare September 9, 2024 15:46
@Coly010 Coly010 enabled auto-merge (squash) September 9, 2024 16:18
@Coly010 Coly010 merged commit 2bc7d4e into master Sep 9, 2024
6 checks passed
@Coly010 Coly010 deleted the module-federation-static-server branch September 9, 2024 16:50
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants