feat(release): add nx release plan:check command to ensure relevant version plans exist
#27343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e191abf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
JamesHenry
force-pushed
the
release-plan-check
branch
2 times, most recently
from
59b25fa to
e77dced
Compare
… version plans exist
JamesHenry
force-pushed
the
release-plan-check
branch
from
9998864 to
ba86124
Compare
JamesHenry
changed the title
nx release plan-check command to ensure relevant version plans existnx release plan:check command to ensure relevant version plans exist
JamesHenry
requested review from
xiongemi,
ndcunningham,
fahslaj and
FrozenPandaz
and removed request for
ndcunningham and
xiongemi
FrozenPandaz
approved these changes
Aug 12, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When using version plans as a versioning strategy with
nx release, there is no way to enforce that version plan files are created when changing files.Expected Behavior
There is a new
nx release plan:checksubcommand, intended to be run in CI (and/or potentially a git hook) which will return with exit code 1 if touched projects are not represented in at least one version plan file on disk.What constitutes a touched file is shared with our
affectedlogic in other commands, with the additionally capability to be able to ignore file patterns from consideration. This would be useful for not requiring version plans when only documentation or spec files change, for example.Related Issue(s)
Fixes #