fix(core): allow configuring plugin message timeout #27315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
force-pushed
the
fix/plugin-iso-timeout
branch
from
e8c31f1 to
73533ef
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 00c4953. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
requested changes
Aug 6, 2024
Comment on lines
26
to
32
| const envValue = process.env.NX_PLUGIN_MESSAGE_TIMEOUT; | ||
| if (envValue) { | ||
| if (envValue === '0' || envValue === 'false') { | ||
| return undefined; | ||
| } | ||
| return parseDuration(envValue); | ||
| } |
There was a problem hiding this comment.
Let's keep it simple by having NX_PLUGIN_NO_TIMEOUTS=true to disable this timeout. No further customization for now
AgentEnder
force-pushed
the
fix/plugin-iso-timeout
branch
from
73533ef to
661a8bb
Compare
AgentEnder
force-pushed
the
fix/plugin-iso-timeout
branch
from
661a8bb to
00c4953
Compare
FrozenPandaz
approved these changes
Aug 6, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 7, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior Plugin messages timeout if they don't hear back in 5 minutes. This adds timeouts to createNodes and other plugin APIs invoked during graph construction, which didn't previously exist ## Expected Behavior Increased timeout + easy configuration via env var ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 0f193e2)
ZackDeRose
pushed a commit
to ZackDeRose/nx
that referenced
this pull request
Aug 8, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior Plugin messages timeout if they don't hear back in 5 minutes. This adds timeouts to createNodes and other plugin APIs invoked during graph construction, which didn't previously exist ## Expected Behavior Increased timeout + easy configuration via env var ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Plugin messages timeout if they don't hear back in 5 minutes. This adds timeouts to createNodes and other plugin APIs invoked during graph construction, which didn't previously exist
Expected Behavior
Increased timeout + easy configuration via env var
Related Issue(s)
Fixes #