fix(linter): convert root projects correctly to inferred and remove default option values #27035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ac9a6bd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
leosvelperez
force-pushed
the
eslint/fix-standalone-convert-to-inferred
branch
2 times, most recently
from
1fa668d to
2452062
Compare
…efault option values
leosvelperez
force-pushed
the
eslint/fix-standalone-convert-to-inferred
branch
from
2452062 to
ac9a6bd
Compare
FrozenPandaz
approved these changes
Jul 22, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 22, 2024
…efault option values (#27035) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Converting a root project to inferred results in the plugin registration to have the `includes` option set to `./**/*`. This is invalid and causes no project to be inferred. Additionally, the eslint `convert-to-inferred` generator: - keeps a redundant `config` option, which is not needed because inferred tasks only work with default/known ESLint config files, so there's no need to specify it in the options - converts all `lintFilePatterns` to `args`, which is correct, but it keeps the patterns that are already inferred by the plugin, which leads to duplicated patterns when running the task ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Converting a root project to inferred should work as expected and result in the `lint` task being inferred for the project. Also, default inferred options should be removed from the target options. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #26775 (cherry picked from commit 5217c33)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Converting a root project to inferred results in the plugin registration to have the
includesoption set to./**/*. This is invalid and causes no project to be inferred.Additionally, the eslint
convert-to-inferredgenerator:configoption, which is not needed because inferred tasks only work with default/known ESLint config files, so there's no need to specify it in the optionslintFilePatternstoargs, which is correct, but it keeps the patterns that are already inferred by the plugin, which leads to duplicated patterns when running the taskExpected Behavior
Converting a root project to inferred should work as expected and result in the
linttask being inferred for the project.Also, default inferred options should be removed from the target options.
Related Issue(s)
Fixes #26775