Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): report should work if project graph errors #26858

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

AgentEnder
Copy link
Member

Current Behavior

When someone runs nx report with a failing graph, the entire report in non-functional. See: #26768

Expected Behavior

When the graph is failing,nx report still shows package versions.

Related Issue(s)

Fixes #

@AgentEnder AgentEnder requested a review from a team as a code owner July 8, 2024 15:05
@AgentEnder AgentEnder requested a review from FrozenPandaz July 8, 2024 15:05
Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 9:07pm

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we refactor this further so that the report still works?

There's logic later on which properly catches the error but it doesn't get hit because of this.

We can move that up and then send the graph in. We have the partial graph now and I think we can make it so that we could sometimes find local plugins.

@AgentEnder AgentEnder requested a review from FrozenPandaz July 8, 2024 18:34
@AgentEnder AgentEnder requested a review from vsavkin as a code owner July 8, 2024 18:35
@AgentEnder AgentEnder force-pushed the fix/report-graph branch 3 times, most recently from 1d9e25d to 98f4fa9 Compare July 9, 2024 15:16
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the benchmark

@AgentEnder AgentEnder merged commit 0b0db78 into master Jul 11, 2024
6 checks passed
@AgentEnder AgentEnder deleted the fix/report-graph branch July 11, 2024 21:35
FrozenPandaz pushed a commit that referenced this pull request Jul 12, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants