-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): report should work if project graph errors #26858
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 01ed3a5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we refactor this further so that the report still works?
There's logic later on which properly catches the error but it doesn't get hit because of this.
We can move that up and then send the graph in. We have the partial graph now and I think we can make it so that we could sometimes find local plugins.
375f7ca
to
53f003f
Compare
53f003f
to
40b7198
Compare
1d9e25d
to
98f4fa9
Compare
98f4fa9
to
01ed3a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the benchmark
(cherry picked from commit 0b0db78)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
When someone runs
nx report
with a failing graph, the entire report in non-functional. See: #26768Expected Behavior
When the graph is failing,
nx report
still shows package versions.Related Issue(s)
Fixes #