fix(nx-dev): allow linking to headers that are code wrapped
#26608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4bd0850. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
before if a header that was using `code` in the title (i.e. launch template) the header should so the link icon but would not link anywhere because the rendered id tag would be an empty string after the id tag is correctly linked by checking the rendering children contains a `code` tag and pulls the code children out. added benefit includes the code headers being linked in the side nav correct too
barbados-clemens
force-pushed
the
docs/allow-linking-code-headers
branch
from
052a919 to
4bd0850
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 21, 2024
before if a header that was using `code` in the title (i.e. launch template) the header should so the link icon but would not link anywhere because the rendered id tag would be an empty string  after the id tag is correctly linked by checking the rendering children contains a `code` tag and pulls the code children out. added benefit includes the code headers being linked in the side nav correct too  Example showing working from preview: https://nx-dev-git-docs-allow-linking-code-headers-nrwl.vercel.app/ci/reference/launch-templates#launchtemplatestemplatenameinitsteps (cherry picked from commit 7699b33)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before if a header that was using
codein the title (i.e. launchtemplate) the header should so the link icon but would not link anywhere
because the rendered id tag would be an empty string
after the id tag is correctly linked by checking the rendering children
contains a
codetag and pulls the code children out.added benefit includes the code headers being linked in the side nav
correct too
Example showing working from preview: https://nx-dev-git-docs-allow-linking-code-headers-nrwl.vercel.app/ci/reference/launch-templates#launchtemplatestemplatenameinitsteps