fix(core): ensure tuple passed to aggregate create nodes error #26456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ae44701. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
requested changes
Jun 7, 2024
| @@ -226,6 +226,11 @@ export class AggregateCreateNodesError extends Error { | |||
| ) { | |||
| super('Failed to create nodes'); | |||
| this.name = this.constructor.name; | |||
| if (!Array.isArray(errors) || (errors.length && errors[0].length !== 2)) { | |||
There was a problem hiding this comment.
I think we should check more than the first element. 🤷 I don't see an reason why not?
AgentEnder
force-pushed
the
fix/plugin-error-handling-destructure-null
branch
from
f07fe16 to
ae44701
Compare
4 tasks
FrozenPandaz
approved these changes
Jun 7, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We throw an invalid aggregate create nodes error if a plugin hard-fails
Expected Behavior
All aggregate create nodes errors are Array
Related Issue(s)
Fixes #