fix(bundling): set project type correct for buildable vite projects #26420
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6f36bbe. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
jaysoo
force-pushed
the
fix/NXC-713
branch
3 times, most recently
from
7382792 to
3790c0b
Compare
jaysoo
force-pushed
the
fix/NXC-713
branch
2 times, most recently
from
5e9fddc to
4f12847
Compare
jaysoo
requested review from
philipjfulcher,
FrozenPandaz,
bcabanes,
MaxKless and
xiongemi
as code owners
packages/nx/src/plugins/package-json-workspaces/create-nodes.spec.ts
Outdated
Show resolved
Hide resolved
| directory.startsWith(nxJson.workspaceLayout.libsDir) | ||
| ) { | ||
| projectConfiguration.projectType = 'library'; | ||
| } |
There was a problem hiding this comment.
How come there's no third case that handles only appsDir being set?
There was a problem hiding this comment.
In that case, we just don't set projectType, which was the previous logic. It's either both appsDir and libsDir, or only libsDir. The rest will fall back to project.type rather than project.data.projectType.
packages/nx/src/plugins/package-json-workspaces/create-nodes.ts
Outdated
Show resolved
Hide resolved
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This PR:
@nx/vite/pluginso that it infers the correctprojectTypepackage-json-workspacesplugin such thatprojectTypeis not inferred isappsDirandlibsDirare not settypeproperty on projects ifprojectTypeis missing (due to no longer being inferred by any plugin).Current Behavior
Expected Behavior
Related Issue(s)
Fixes #