Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): handleErrors returns an exit code #26343

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

AgentEnder
Copy link
Member

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@AgentEnder AgentEnder requested a review from a team as a code owner June 3, 2024 22:04
@AgentEnder AgentEnder requested a review from FrozenPandaz June 3, 2024 22:04
Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 9:59pm

@AgentEnder AgentEnder force-pushed the fix/handle-errors-exit-code branch from 4f93ff9 to 326afde Compare June 3, 2024 22:11
@FrozenPandaz FrozenPandaz enabled auto-merge (squash) June 3, 2024 23:59
@FrozenPandaz FrozenPandaz disabled auto-merge June 4, 2024 02:20
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you remove the what would now be redundant handling we have in the release command handlers as well?

@AgentEnder AgentEnder force-pushed the fix/handle-errors-exit-code branch from 326afde to c86e95d Compare June 4, 2024 19:06
@AgentEnder AgentEnder force-pushed the fix/handle-errors-exit-code branch 2 times, most recently from 3a4b631 to c0535ab Compare June 4, 2024 20:57
@AgentEnder AgentEnder force-pushed the fix/handle-errors-exit-code branch from c0535ab to 04dab14 Compare June 4, 2024 21:57
@AgentEnder AgentEnder requested a review from JamesHenry June 4, 2024 22:06
@AgentEnder AgentEnder merged commit d06992e into master Jun 4, 2024
6 checks passed
@AgentEnder AgentEnder deleted the fix/handle-errors-exit-code branch June 4, 2024 22:44
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants