fix(misc): ensure plugins are not creating workspace context while creating nodes #26253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgentEnder
requested review from
a team,
FrozenPandaz,
xiongemi and
Coly010
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ef5c4b5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
fix/daemon-glob
branch
from
f6b637d to
696c588
Compare
AgentEnder
force-pushed
the
fix/daemon-glob
branch
from
696c588 to
68f8577
Compare
AgentEnder
force-pushed
the
fix/daemon-glob
branch
from
68f8577 to
0b154f6
Compare
AgentEnder
force-pushed
the
fix/daemon-glob
branch
from
0b154f6 to
f95862f
Compare
AgentEnder
force-pushed
the
fix/daemon-glob
branch
from
f95862f to
9d88946
Compare
AgentEnder
force-pushed
the
fix/daemon-glob
branch
from
6a38e6b to
0445036
Compare
AgentEnder
force-pushed
the
fix/daemon-glob
branch
from
0445036 to
16754df
Compare
leosvelperez
approved these changes
May 31, 2024
| @@ -25,6 +26,8 @@ describe('@nx/jest/plugin', () => { | |||
| configFiles: [], | |||
| }; | |||
|
|
|||
| setWorkspaceRoot(tempFs.tempDir); | |||
There was a problem hiding this comment.
nit: is this needed? AFAICT, we already do this in the TempFs constructor: https://github.com/nrwl/nx/blob/master/packages/nx/src/internal-testing-utils/temp-fs.ts#L30-L32.
There was a problem hiding this comment.
Good catch, this came from the throw 💩 at the wall and see what sticks debugging portion of development 😅.
I've confirmed its not needed, and removed.
AgentEnder
force-pushed
the
fix/daemon-glob
branch
from
16754df to
64d03a6
Compare
AgentEnder
force-pushed
the
fix/daemon-glob
branch
from
64d03a6 to
3859e9a
Compare
AgentEnder
force-pushed
the
fix/daemon-glob
branch
from
3859e9a to
88fa1c4
Compare
FrozenPandaz
requested changes
May 31, 2024
| }); | ||
|
|
||
| it('should run successfully', async () => { | ||
| await expect(filterGenerator(tree, options)).resolves.not.toThrowError(); | ||
| await filterGenerator(tree, options); | ||
| expect(true).toBe(true); |
AgentEnder
force-pushed
the
fix/daemon-glob
branch
from
6f09598 to
9d8c7d0
Compare
FrozenPandaz
approved these changes
May 31, 2024
AgentEnder
force-pushed
the
fix/daemon-glob
branch
from
9d8c7d0 to
ef5c4b5
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eating nodes
Current Behavior
Some plugins utilize
globWithWorkspaceContextto perform a glob search duringcreateNodes. This works fine without plugin isolation, and would still "work" with it, but when plugins are isolated they don't share a workspace context. Combine this with the daemon and we have issues.Expected Behavior
If the daemon is enabled, its workspace context is utilized when performing glob searches
Related Issue(s)
Fixes #