fix(core): prevent graph output from being truncated #23446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 481413f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
isaacplmann
approved these changes
May 16, 2024
FrozenPandaz
requested changes
May 16, 2024
docs/generated/cli/affected.md
Outdated
| @@ -65,6 +65,24 @@ Use the currently executing project name in your command.: | |||
| nx affected -t build --tag=$NX_TASK_TARGET_PROJECT:latest | |||
| ``` | |||
|
|
|||
| Preview the task graph that Nx would run inside a webview.: | |||
There was a problem hiding this comment.
Suggested change
| Preview the task graph that Nx would run inside a webview.: | |
| Preview the task graph that Nx would run inside a webview: |
Please fix this everywhere
FrozenPandaz
requested changes
May 16, 2024
| @@ -53,13 +53,13 @@ Show affected projects in the workspace, excluding end-to-end projects: | |||
| nx show projects --affected --exclude=*-e2e | |||
| ``` | |||
|
|
|||
| Show detailed information about "my-app" in a json format.: | |||
| Show detailed information about "my-app" in a json format: | |||
|
|
|||
| ```shell | |||
| nx show project my-app | |||
There was a problem hiding this comment.
Please make sure this is correct..
docs/generated/cli/graph.md
Outdated
| Print the project graph as JSON to the console: | ||
|
|
||
| ```shell | ||
| nx graph --file=stdout |
AgentEnder
force-pushed
the
fix/graph-output-shouldnt-be-truncated
branch
2 times, most recently
from
5b9cd52 to
03685f9
Compare
FrozenPandaz
requested changes
May 27, 2024
docs/generated/cli/graph.md
Outdated
| @@ -89,7 +95,7 @@ Exclude certain projects from being processed | |||
|
|
|||
| Type: `string` | |||
|
|
|||
| Output file (e.g. --file=output.json or --file=dep-graph.html) | |||
| Output file (e.g. --file=output.json or --file=dep-graph.html). Provide --file=stdout to print the project graph in the terminal. | |||
There was a problem hiding this comment.
Let's not recommend this.
docs/generated/cli/graph.md
Outdated
|
|
||
| Type: `boolean` | ||
|
|
||
| Print the project graph in the terminal. (equivalent to --file=stdout) |
There was a problem hiding this comment.
I don't think we have to mention that it's equivalent?
AgentEnder
force-pushed
the
fix/graph-output-shouldnt-be-truncated
branch
from
03685f9 to
481413f
Compare
FrozenPandaz
approved these changes
May 31, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 3, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior --graph stdout and --file stdout aren't documented. When printing graph to stdout, its possible for some output to get missed. ## Expected Behavior Existing flags are documented, and `--print` is more discoverable. We await stdout finishing before exiting the program. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #18689 (cherry picked from commit a308e1d)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
--graph stdout and --file stdout aren't documented. When printing graph to stdout, its possible for some output to get missed.
Expected Behavior
Existing flags are documented, and
--printis more discoverable. We await stdout finishing before exiting the program.Related Issue(s)
Fixes #18689