Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(core): addPlugin should not conflict on project.json targ… #23391

Merged
merged 1 commit into from
May 14, 2024

Conversation

FrozenPandaz
Copy link
Collaborator

…ets (#23264)"

This reverts commit 85c8916

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested review from a team and Coly010 as code owners May 14, 2024 20:58
@FrozenPandaz FrozenPandaz requested a review from AgentEnder May 14, 2024 20:58
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 9:17pm

@FrozenPandaz FrozenPandaz requested a review from ndcunningham May 14, 2024 20:58
@FrozenPandaz FrozenPandaz merged commit cfadd7d into master May 14, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the revert-pr branch May 14, 2024 22:01
FrozenPandaz added a commit that referenced this pull request May 14, 2024
#23391)

…ets (#23264)"

This reverts commit 85c8916

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit cfadd7d)
Coly010 pushed a commit that referenced this pull request May 15, 2024
#23391)

…ets (#23264)"

This reverts commit 85c8916

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants