-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nx-cloud): ensure generated ci workflows use dlx for nx-cloud #23333
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3e0d569. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
@@ -1,5 +1,5 @@ | |||
{ | |||
"extends": ["../../.eslintrc.base.json"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me, but the eslint changes should be reverted.
Approving to unlock the PR
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
E.g.
pnpm exec nx-cloud
is used, which will fail to find the nx-cloud executable because node_modules have not yet been installed.Expected Behavior
E.g.
pnpm dlx nx-cloud
is used, which can resolve the nx-cloud executable without node_modules.Related Issue(s)
Fixes #