Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-cloud): ensure generated ci workflows use dlx for nx-cloud #23333

Merged
merged 1 commit into from
May 13, 2024

Conversation

JamesHenry
Copy link
Collaborator

Current Behavior

E.g. pnpm exec nx-cloud is used, which will fail to find the nx-cloud executable because node_modules have not yet been installed.

Expected Behavior

E.g. pnpm dlx nx-cloud is used, which can resolve the nx-cloud executable without node_modules.

Related Issue(s)

Fixes #

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 13, 2024 0:55am

@JamesHenry JamesHenry marked this pull request as ready for review May 13, 2024 12:54
@JamesHenry JamesHenry requested review from a team as code owners May 13, 2024 12:54
@JamesHenry JamesHenry requested a review from FrozenPandaz May 13, 2024 12:54
@@ -1,5 +1,5 @@
{
"extends": ["../../.eslintrc.base.json"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed?

Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me, but the eslint changes should be reverted.

Approving to unlock the PR

@JamesHenry JamesHenry merged commit 8cda56e into master May 13, 2024
6 checks passed
@JamesHenry JamesHenry deleted the workflows-nx-cloud-dlx branch May 13, 2024 13:50
FrozenPandaz pushed a commit that referenced this pull request May 13, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants