fix(core): fix missing import

[chabb]

Current Behavior

The import for performance is missing, which causes an error to appear

Expected Behavior

No error should occured

Related Issue(s)

Fixes #

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	May 1, 2024 10:59am

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a38dd32. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --targets=e2e,e2e-ci --base=22ef42a475f14fdc8734a9d21f73d42f05f1f28e --head=a38dd32ae18d7c828fb3d5e03febed1a3de60d98 --parallel=1
• nx affected --targets=lint,test,build --base=22ef42a475f14fdc8734a9d21f73d42f05f1f28e --head=a38dd32ae18d7c828fb3d5e03febed1a3de60d98 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=22ef42a475f14fdc8734a9d21f73d42f05f1f28e --head=a38dd32ae18d7c828fb3d5e03febed1a3de60d98
• nx documentation --no-dte
• nx affected -t e2e-macos-ci --parallel=1 --base=22ef42a475f14fdc8734a9d21f73d42f05f1f28e --head=a38dd32ae18d7c828fb3d5e03febed1a3de60d98

---

Sent with 💌 from NxCloud.

[AgentEnder]

Hey 👋 - performance is available on Node 16 and higher, which means that its available for all of the node versions we currently target.

I'm going to accept this PR, but for future reference you may encounter other issues if using a lower node version. See: https://nx.dev/nx-api/workspace/documents/nx-nodejs-typescript-version-matrix

[chabb]

This was actually breaking with node v20. According to the doc, you need to do the import, see https://nodejs.org/api/perf_hooks.html

[alaingiller]

I'm using node 20.12.0 and have this problem with the last nx version when I run jest test for my nx angular application plugin.
The problem is probably because 'perf_hooks' is imported in same places but not here and probably related to nx cypress plugin.

[AgentEnder]

Here's the docs that show perf was added as a global in node v16, if you get an error about it not being defined then there is something causing Nx to be ran with a different node version than you are expecting. https://nodejs.org/docs/latest/api/globals.html#performance

You can test this locally in your terminal with node -p "performance.now()".

[alaingiller]

Agree, and I've it in node, and I've only one instance of node, the version 20, but with the last version of nx, I got this problem while running jest.
command: nx run my-project:test --coverage
node: v20.12.2
Error:

    LoadPluginError: Could not load plugin /builds/xxxx/my-nxplugin-jslib/node_modules/nx/src/plugins/project-json/build-nodes/package-json-next-to-project-json
      at loadNxPluginAsync (../../node_modules/nx/src/project-graph/plugins/loader.js:207:15)
      at loadNxPlugin (../../node_modules/nx/src/project-graph/plugins/loader.js:180:9)
      at loadNxPlugins (../../node_modules/nx/src/project-graph/plugins/internal-api.js:46:48)
      at buildProjectGraphAndSourceMapsWithoutDaemon (../../node_modules/nx/src/project-graph/project-graph.js:75:32)
      at createProjectGraphAndSourceMapsAsync (../../node_modules/nx/src/project-graph/project-graph.js:201:25)
      at createProjectGraphAsync (../../node_modules/nx/src/project-graph/project-graph.js:190:39)
      at initEsLint (../../node_modules/@nx/eslint/src/generators/init/init.js:41:19)
      at lintInitGenerator (../../node_modules/@nx/eslint/src/generators/init/init.js:80:12)
      at lintProjectGeneratorInternal (../../node_modules/@nx/eslint/src/generators/lint-project/lint-project.js:25:22)
      at addLintingGenerator (../../node_modules/@nx/angular/src/generators/add-linting/add-linting.js:14:22)
      at addLinting (../../node_modules/@nx/angular/src/generators/library/library.js:123:5)
      at libraryGeneratorInternal (../../node_modules/@nx/angular/src/generators/library/library.js:69:5)
      at libraryGenerator (../../node_modules/@nx/angular/src/generators/library/library.js:25:12)
    Cause:
    TypeError: performance.mark is not a function
      at loadNxPluginAsync (../../node_modules/nx/src/project-graph/plugins/loader.js:198:21)
      at loadNxPlugin (../../node_modules/nx/src/project-graph/plugins/loader.js:180:9)
      at loadNxPlugins (../../node_modules/nx/src/project-graph/plugins/internal-api.js:46:48)
      at buildProjectGraphAndSourceMapsWithoutDaemon (../../node_modules/nx/src/project-graph/project-graph.js:75:32)
      at createProjectGraphAndSourceMapsAsync (../../node_modules/nx/src/project-graph/project-graph.js:201:25)
      at createProjectGraphAsync (../../node_modules/nx/src/project-graph/project-graph.js:190:39)
      at initEsLint (../../node_modules/@nx/eslint/src/generators/init/init.js:41:19)
      at lintInitGenerator (../../node_modules/@nx/eslint/src/generators/init/init.js:80:12)
      at lintProjectGeneratorInternal (../../node_modules/@nx/eslint/src/generators/lint-project/lint-project.js:25:22)
      at addLintingGenerator (../../node_modules/@nx/angular/src/generators/add-linting/add-linting.js:14:22)
      at addLinting (../../node_modules/@nx/angular/src/generators/library/library.js:123:5)

But with this patch, it is working

[JamesHenry]

@AgentEnder @alaingiller I imagine this is a jest testEnvironment issue. I imagine @alaingiller is using jsdom or a custom one where the global won't exist?

(Providing the snippet from Craigory node -p "performance.now()" is working as expected that is)

[alaingiller]

Good point, I effectively have jest-environment-jsdom.
BUT This is the standard generated by npx create-nx-plugin my-plugin like describe in https://nx.dev/extending-nx/tutorials/create-plugin, so nothing custom.

[chabb]

@JamesHenry @AgentEnder. npx create-nx-plugin generates a project that uses the nx jest plugin

.The jest plugin uses jsdom under the hood : jsdom/jsdom#3309. Jsdom does not implement the performance API ( e.g jsdom/jsdom#3309 ). This is why we have this error when running the tests.
But IHMO, we should not use an evironment that simulates the browser here. For a plugin, I think it makes more sense to use node as the test environment. Using this jest config solves this issue:

module.exports = { ...nxPreset, testEnvironment: 'node' };

Maybe we can update the generator to use node for tests ( for plugin )

That way, you could remove all those perf-hooks import, and things would work out of the box

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

[JamesHenry]

@chabb Thanks that makes sense, I'll open an issue to track