fix(core): recursive resolve deps on create command graph

[Naymi]

introductory

Current Behavior

nx exec --projects=my-node-app -- pwd
TypeError: graph.dependencies[id] is not iterable
    at _findCycle (/Users/anatolijfedorov/prjcts/tmp/nx-nest-workspace/node_modules/nx/src/tasks-runner/task-graph-utils.js:8:39)
    at _findCycle (/Users/anatolijfedorov/prjcts/tmp/nx-nest-workspace/node_modules/nx/src/tasks-runner/task-graph-utils.js:11:23)
    at findCycle (/Users/anatolijfedorov/prjcts/tmp/nx-nest-workspace/node_modules/nx/src/tasks-runner/task-graph-utils.js:23:23)
    at createCommandGraph (/Users/anatolijfedorov/prjcts/tmp/nx-nest-workspace/node_modules/nx/src/commands-runner/create-command-graph.js:25:52)
    at getCommandProjects (/Users/anatolijfedorov/prjcts/tmp/nx-nest-workspace/node_modules/nx/src/commands-runner/get-command-projects.js:7:72)
    at runScriptAsNxTarget (/Users/anatolijfedorov/prjcts/tmp/nx-nest-workspace/node_modules/nx/src/command-line/exec/exec.js:60:73)
    at Object.nxExecCommand (/Users/anatolijfedorov/prjcts/tmp/nx-nest-workspace/node_modules/nx/src/command-line/exec/exec.js:44:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Object.handler (/Users/anatolijfedorov/prjcts/tmp/nx-nest-workspace/node_modules/nx/src/command-line/exec/command-object.js:11:13)

Expected Behavior

nx exec --projects=my-node-app -- pwd
/tmp/nx-nest-workspace/my-node-lib-2
/tmp/nx-nest-workspace/my-node-lib
/tmp/nx-nest-workspace/apps/my-node-app

Fixes #22994
Added function that resolves dependencies recursively

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	Jul 5, 2024 2:43am

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1c84ff0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 10 targets

• nx release publish --registry=https://registry.npmjs.org/ --tag=canary --output-style=dynamic --parallel=8
• nx run-many -t add-extra-dependencies --parallel 8
• nx run-many --target=artifacts
• nx copy-native-package-directories nx
• nx run-many --target build --parallel 8 --exclude nx-dev,typedoc-theme,tools-documentation-create-embeddings
• nx run-many --target=build-native -- --target=aarch64-pc-windows-msvc
• nx run-many --target=build-native -- --target=x86_64-pc-windows-msvc
• nx run-many --target=build-native -- --target=aarch64-apple-darwin
• nx run-many --target=build-native -- --target=x86_64-apple-darwin
• nx run-many --target=build-native -- --target=armv7-unknown-linux-gnueabihf

---

Sent with 💌 from NxCloud.

[xiongemi]

is there a link to your project with above project graph? i want to test it out.

[Naymi]

is there a link to your project with above project graph? i want to test it out.

Yeah, https://github.com/Naymi/nx-exec-recursive-demo

more details here #22994

[vaharoni]

This fix seems to run the command on the project's dependencies as well:

$ nx exec -p my-node-app -- pwd
/Users/me/workspace/nx-exec-recursive-demo/my-node-lib-2
/Users/me/workspace/nx-exec-recursive-demo/my-node-lib
/Users/me/workspace/nx-exec-recursive-demo/apps/my-node-app

I would expect it to work on the specified project only and therefore output just the last line above. Now, I'm completely new to Nx, so could be wrong with the intent behind nx exec. But I think I saw in the documentation that the task graph and project graph aren’t necessarily isomorphic, as this fix seems to force (if we equate the commands being executed with tasks).

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.