Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): rename languageSettings to languageOptions for flat config migration #22924

Merged

Conversation

pumano
Copy link
Contributor

@pumano pumano commented Apr 20, 2024

partially fixes #22782

Current Behavior

after run migration eslint to flat config it migrate parserOptions to languageSettings, while eslint does not have that, and have languageOptions

Expected Behavior

migrate to languageOptions

Related Issue(s)

@pumano pumano requested a review from a team as a code owner April 20, 2024 08:21
@pumano pumano requested a review from JamesHenry April 20, 2024 08:21
Copy link

vercel bot commented Apr 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 1:20pm

@pumano pumano force-pushed the fix/language-options-eslint-migration branch from 4a7001a to 59e17cb Compare April 22, 2024 13:19
@pumano
Copy link
Contributor Author

pumano commented Apr 24, 2024

@meeroslav would love if you can check it

@JamesHenry JamesHenry merged commit 7561e71 into nrwl:master May 11, 2024
6 checks passed
@JamesHenry
Copy link
Collaborator

Thanks a lot @pumano!

Please can you clarify what you mean by "partially fixes"? Does it not completely fix it?

FrozenPandaz pushed a commit that referenced this pull request May 13, 2024
@pumano
Copy link
Contributor Author

pumano commented May 14, 2024

Thanks a lot @pumano!

Please can you clarify what you mean by "partially fixes"? Does it not completely fix it?

This PR only fixes problem for languageOptions, but "override" languageOptions with "parserOptions: { project: 'tsconfig.*?.ts'" not working globally for me, but I fix it, manually add to all libs.

Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The @nx/eslint:convert-to-flat-config migration generator does not migrate parserOptions property correctly
2 participants