feat(core): add support for pnpm lockfile v9 #22906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
meeroslav
force-pushed
the
bump-pnpm-to-9
branch
from
2bd12b1 to
fc1bdbc
Compare
meeroslav
changed the title
meeroslav
force-pushed
the
bump-pnpm-to-9
branch
from
fc1bdbc to
d4176c3
Compare
4 tasks
|
great work @meeroslav ! would it also be useful to raise an error if the |
meeroslav
force-pushed
the
bump-pnpm-to-9
branch
from
d4176c3 to
1f09f2a
Compare
meeroslav
force-pushed
the
bump-pnpm-to-9
branch
from
8e76559 to
d81af51
Compare
binary64
added a commit
to binary64/blabber
that referenced
this pull request
May 6, 2024
4 tasks
meeroslav
commented
May 22, 2024
| result[key] = snapshot; | ||
| } else { | ||
| snapshot['dev'] = false; // all dependencies are prod | ||
| if (lockfileVersion < 9) { |
FrozenPandaz
approved these changes
May 27, 2024
|
This is amazing news! That’s the last link in the chain needed for pnpm@9 support for Nx 🙌 thank you so much |
ndcunningham
pushed a commit
that referenced
this pull request
May 28, 2024
- [X] Fix parenthesis separator detection - [x] Fix leading dash detection - [x] Migrate existing pnpm normalizer to latest code - [X] Add unit tests for v9 - [X] Dogfooding Pnpm v9 to Nx repo and agents Fixes regression with alias packages introduced via #23017 ## Benchmarks PNPM v9 Branch (migrated to branch's code) ``` Time (mean ± σ): 3.526 s ± 0.081 s [User: 0.717 s, System: 0.948 s] Range (min … max): 3.390 s … 3.714 s 20 runs ``` Master (running nx 19.1.0-beta.3) ``` Time (mean ± σ): 11.160 s ± 0.112 s [User: 0.799 s, System: 0.979 s] Range (min … max): 10.955 s … 11.379 s 20 runs ``` ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #22850 Fixes #23256 --------- Co-authored-by: James Henry <[email protected]>
4 tasks
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression with alias packages introduced via #23017
Benchmarks
PNPM v9 Branch (migrated to branch's code)
Master (running nx 19.1.0-beta.3)
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #22850
Fixes #23256