Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): use precise-commits for formatting #229

Closed
wants to merge 1 commit into from
Closed

Conversation

JamesHenry
Copy link
Collaborator

@JamesHenry JamesHenry commented Jan 24, 2018

  • Adds precommit hook to validate staged code changes
    • Expected workflow right now is that if the check fails in the precommit hook, you would run yarn format, restage and recommit.
  • Updates formatting check for PRs on Travis
  • Removes old formatting scripts

I've kept the singleQuote preference by adding a .prettierrc file, but left out the printWidth configuration as we had previously discussed reverting to the default.

Note: There is some noise in the package.json from packages moving around as it appears they were added manually in the past and were not in alphabetical order.

@JamesHenry JamesHenry force-pushed the pl branch 2 times, most recently from 44f0d19 to 903bf38 Compare January 24, 2018 19:39
@JamesHenry JamesHenry changed the title WIP - DO NOT MERGE chore(build): use precise-commits for formatting Jan 24, 2018
@JamesHenry JamesHenry requested a review from vsavkin January 24, 2018 20:03
@jeffbcross
Copy link
Member

Merged at db44931

@jeffbcross jeffbcross closed this Feb 1, 2018
@vsavkin vsavkin deleted the pl branch June 19, 2019 20:38
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants