-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(angular): generate public
directory instead of assets
#22801
feat(angular): generate public
directory instead of assets
#22801
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
1d9a72f
to
d26c9a8
Compare
d26c9a8
to
783afba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also update the host generator (might be setup-mf) when dynamic is true to generate the module federation manifest in public directory, as well as update the bootstrap template to fetch from the correct directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Upstream change: angular/angular-cli@6530aa1
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #