feat(core): add bun package manager

[Jordan-Hall]

Bun uses yarn lock for it's binary file. Running the binary will produce the content of a yarn lock file (v1)

Other option is to use the -y command on add and install. This will create a yarn lock file and then createLockFile can just modify the yarn.lock file instead?

This is the PR made from #19113 and pushed due to #22402 being closed.

PS Bun feels more stable since the PR was first created!

This PR will resolve #22283 and start of #21075

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	May 22, 2024 2:58pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 631c414. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --targets=e2e,e2e-ci --base=08ef0e4bde845669b9cfef183d50c856e7a6293f --head=631c414c2ce8b80bd7e72bfc0d769378ab06c7fa --parallel=1
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx affected --targets=lint,test,build --base=08ef0e4bde845669b9cfef183d50c856e7a6293f --head=631c414c2ce8b80bd7e72bfc0d769378ab06c7fa --parallel=3
• nx-cloud record -- nx format:check --base=08ef0e4bde845669b9cfef183d50c856e7a6293f --head=631c414c2ce8b80bd7e72bfc0d769378ab06c7fa
• nx documentation --no-dte
• nx affected -t e2e-macos-ci --parallel=1 --base=08ef0e4bde845669b9cfef183d50c856e7a6293f --head=631c414c2ce8b80bd7e72bfc0d769378ab06c7fa

---

Sent with 💌 from NxCloud.

[Jordan-Hall]

@edbzn Would it be worth calling stringifyYarnLockfile? But would have to edit how it is created into a file because it is a self-executable file

[Jordan-Hall]

My thinking is moving the following into a util

const lockFile = createLockFile(
      builtPackageJson,
      context.projectGraph,
      packageManager
    );
    writeFileSync(
      `${outDirRelativeToWorkspaceRoot}/${getLockFileName(packageManager)}`,
      lockFile,
      {
        encoding: 'utf-8',
      }
    );

its duplicated code but run IF check for bun and use the bun CLI to generate the binary file

[edbzn]

Worth asking @meeroslav, he knows best how to deal with lockfiles

[jaysoo]

We should reuse stringifyYarnLockfile to parse the file, as long as it handles bun-specific strings: # bun at the top, and version "workspace:<proj>" if using bun workspaces.

[meeroslav]

Since there doesn't seem to be a way to generate bun.lockb without running the install, I would use the stringifyYarnLockfile to be as close as possible to the intended package versions.

[Jordan-Hall]

I'm looking at generating the binary file. Happy to update snapshot so this can go in and work on that after? Also love to get involved in adding runtime and bun test. I have plugin that does it for now, but be nice if NX can add native support

[Jordan-Hall]

@jaysoo If you want to make the yarn.lock a follow up then I think this PR is completed?

[laynef]

I reused Yarn in my PR bro. They still had problems with it. The people want Bun support!

If it builds and runs, then that's a start.

Help us brothers out for taking the time to do this for you.

It was my birthday btw when I built a working version for your project.

[Jordan-Hall]

This is different, this is to handle the manual creation of lock files not the reading of the lock file. Nx team doing a great job BTW, they been so many unstable issues. The chunk of this was taken from my PR back in Sep 11, 2023. But I closed it due to Bun having too many bugs

[Jordan-Hall]

@laynef you can always use nx-bun to get started for now

[Jordan-Hall]

cc: @JamesHenry

[Jordan-Hall]

I was working in WSL. I'll fix the test in the morning on my Linux laptop

[JamesHenry]

Thanks a lot for this @Jordan-Hall!

We will need some e2e coverage in addition to the comments

[FrozenPandaz]

Thank you for your work here! 👍

[benpsnyder]

We are setting aside resources in the coming weeks to battle test bun in our repos with Nx and we'll submit PRs and open issues as necessary. Very excited about this. Thanks to all

[Jordan-Hall]

I've had bun test working with NX it really good. Happy to help get a plugin in NX to support both runtime and tests. Would need guidance though by the team. I feel the node should turn into runtime and work with node and bun at least the generators

[Jordan-Hall]

@FrozenPandaz I think this is ready now. Let me know if you have any queries or any more issues :)

[jaysoo]

@jaysoo are you on slack or discord. I'm confused why this is failing. Build and lint ok. Looks to me its a codeowner issue

Yes, I'm on Discord. I'll take a look at the errors now and try to push a fix.

[jaysoo]

Trying a run here to see if it'll go green #25066

Need to debug further on why CI is failing.

[Jordan-Hall]

Trying a run here to see if it'll go green #25066

Need to debug further on why CI is failing.

Thank you. I'm around now on laptop if you need anything

[Jordan-Hall]

Yes yes yes @jaysoo merge before it goes again 🤣

[jaysoo]

Pushed a WIP PR to see how e2e tests are when we force Bun, since they are running with pnpm right now. If things are green or mostly green then we're good to go.

[Jordan-Hall]

Can I ask what the issue was with the ci :/ be good for future reference if I make anymore prs

[jaysoo]

We'll need a follow-up to make sure that --generatePackageJson for executors that support it won't error out due to missing lockfiles. For Bun, we'll just skip the lockfile for now, and discuss whether generating yarn.lock file would be preferable.

This is the code we need to fix: https://github.com/nrwl/nx/blob/master/packages/js/src/utils/package-json/update-package-json.ts#L106-L118.

[Jordan-Hall]

We'll need a follow-up to make sure that --generatePackageJson for executors that support it won't error out due to missing lockfiles. For Bun, we'll just skip the lockfile for now, and discuss whether generating yarn.lock file would be preferable.

This is the code we need to fix: https://github.com/nrwl/nx/blob/master/packages/js/src/utils/package-json/update-package-json.ts#L106-L118.

Happy to make that PR later

[jaysoo]

Here's the PR :)

#25158

[jaysoo]

You can try this now in canary.

npx create-nx-workspace@canary --packageManager=bun

[benpsnyder]

First issue filed. Going to spend some hours debugging this and will post findings there.

When using Bun and building within Dockerfile - Failed to process project graph. Run "nx reset" to fix this.' re: 'nx/js/dependencies-and-lockfile (#25965)

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.