fix(core): expand env variables on load and unload #22585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Env variables using other variables were not unloaded from the environment and further customizations were impossible in more specific env files.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 79ce059. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
|
@AgentEnder @Coly010 your feedback here will be appreciated 🙏 |
This was referenced Jun 5, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 26, 2024
This pr is meant to replace #22585 and #20524 Env variables using other variables were not unloaded from the environment and further customizations were impossible in more specific env files. <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #23581 Co-authored-by: Mateo Tibaquira <[email protected]>
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 26, 2024
This pr is meant to replace #22585 and #20524 Env variables using other variables were not unloaded from the environment and further customizations were impossible in more specific env files. <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #23581 Co-authored-by: Mateo Tibaquira <[email protected]> (cherry picked from commit 88fd03b)
|
create a pr #26459 to replace this. |
|
Thank you @xiongemi! |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Env variables using other variables were not unloaded from the environment and further customizations were impossible in more specific env files.
Current Behavior
The unloading and re-loading of env variables in task-runner/task-env is faulty because composed variables are not unloaded because they are not expanded, just parsed and checked to be equal to the process.env value.
I'm using the
@nx-tools/nx-containerplugin to build Docker images and I'm passing some input parameters via env var like:Nx loads
.env,.local.envand.env.localby default and I have the localhost configuration in one of them.But when I want to build for
productionI want to get the values of.env.productionand debugging the issue deeply I found that my var was not unloaded because it was comparing the evaluated value in process.env (INPUT_BUILD_ARGS="API_HOST=localhost\nAPI_PORT=3000") with the non-expanded value (INPUT_BUILD_ARGS="API_HOST=${API_HOST}\nAPI_PORT=${API_PORT}") so it was not unloaded.After this adjustment and the upgrade of
dotenv-expandto not affect process.env it works successfully :)Expected Behavior
To have my composed variables expanded so they are correctly unloaded and overridden by a specific
.env*file.