Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): HMR for withModuleFederation #22300 #22562

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Mar 28, 2024

Current Behavior

HMR for React Module Federation is not currently functioning as expected

Expected Behavior

HMR for React Module Federation should work as expected.
Only set runtimeChunk: single for initial host application, and only when mode === development

Related Issue(s)

Fixes #22300

@Coly010 Coly010 requested a review from a team as a code owner March 28, 2024 16:08
@Coly010 Coly010 requested a review from xiongemi March 28, 2024 16:08
@Coly010 Coly010 self-assigned this Mar 28, 2024
Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 4:09pm

@Coly010 Coly010 merged commit 6183944 into nrwl:master Mar 28, 2024
6 checks passed
@Coly010 Coly010 deleted the mf/initial-host-hmr-react branch March 28, 2024 17:02
Copy link

github-actions bot commented Apr 4, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR initializing and executing, but not painting in browser
2 participants