feat(core): re-enable running plugins in isolation #22527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1647d55. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
feat/plugin-isolation-behind-flag
branch
from
057d270 to
bf22c0b
Compare
AgentEnder
force-pushed
the
feat/plugin-isolation-behind-flag
branch
from
bf22c0b to
4258ae0
Compare
AgentEnder
force-pushed
the
feat/plugin-isolation-behind-flag
branch
from
4258ae0 to
12fc486
Compare
AgentEnder
force-pushed
the
feat/plugin-isolation-behind-flag
branch
from
12fc486 to
bc2fe87
Compare
AgentEnder
force-pushed
the
feat/plugin-isolation-behind-flag
branch
from
bc2fe87 to
9ece602
Compare
AgentEnder
force-pushed
the
feat/plugin-isolation-behind-flag
branch
from
9ece602 to
a7af95f
Compare
AgentEnder
force-pushed
the
feat/plugin-isolation-behind-flag
branch
from
a7af95f to
49fee61
Compare
AgentEnder
force-pushed
the
feat/plugin-isolation-behind-flag
branch
from
49fee61 to
0536012
Compare
AgentEnder
force-pushed
the
feat/plugin-isolation-behind-flag
branch
from
0536012 to
bcd7337
Compare
AgentEnder
force-pushed
the
feat/plugin-isolation-behind-flag
branch
from
bcd7337 to
b61b9b8
Compare
AgentEnder
force-pushed
the
feat/plugin-isolation-behind-flag
branch
from
b61b9b8 to
4fd0612
Compare
AgentEnder
force-pushed
the
feat/plugin-isolation-behind-flag
branch
from
ac7da86 to
1647d55
Compare
FrozenPandaz
approved these changes
Apr 9, 2024
| ) | ||
| ) | ||
| ); | ||
| const [plugins] = await loadNxPlugins(nxJson?.plugins ?? [], workspaceRoot); |
There was a problem hiding this comment.
Make sure this gets cleaned up.
FrozenPandaz
requested review from
meeroslav,
a team and
leosvelperez
as code owners
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c01b566.
Current Behavior
Plugin isolation was reverted.
Expected Behavior
Plugin isolation was un-reverted behind a flag which is
NX_ISOLATE_PLUGINS=trueRelated Issue(s)
Fixes #