fix(testing): close cypress web server correctly on windows #22125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7b98632. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
leosvelperez
force-pushed
the
cypress/windows-kill-web-server-process
branch
from
20efc8f to
7b98632
Compare
FrozenPandaz
approved these changes
Mar 4, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 8, 2024
(cherry picked from commit 2d9ecfd)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Cypress fails to close the web server on Windows. It fails with
Error: kill ESRCH(https://github.com/nrwl/nx/actions/runs/8135984708/job/22231576219#step:11:264). This happens because Node.js doesn't support killing process groups in Windows (https://nodejs.org/docs/latest-v20.x/api/process.html#processkillpid-signal) and because we're not spawning a detached process for Windows anyway.Expected Behavior
Cypress should close the web server on Windows.
Successful run: https://github.com/nrwl/nx/actions/runs/8139220425/job/22242149713#step:11:201. There are unrelated failures on that run, but the failures specific to not closing the web server are addressed.
Related Issue(s)
Fixes #