fix(graph): don't show open config button on nx.dev & refactor tooltips #21463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxKless
requested review from
philipjfulcher,
FrozenPandaz and
bcabanes
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit df47c9d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
requested changes
Feb 1, 2024
MaxKless
force-pushed
the
fix-open-config-in-nxdev
branch
from
5f6a69c to
7f73fac
Compare
FrozenPandaz
approved these changes
Feb 1, 2024
MaxKless
force-pushed
the
fix-open-config-in-nxdev
branch
from
7f73fac to
df47c9d
Compare
FrozenPandaz
pushed a commit
to FrozenPandaz/nx
that referenced
this pull request
Feb 1, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
I also refactored parts of the tooltip flow so that all actions (opening config, running a task in console, ...) are specified in the same place.