Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): ensure leading v is stripped from provided semver version #20815

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

JamesHenry
Copy link
Collaborator

Current Behavior

v17.2.5 was accidentally published (with a leading v) and it turns out that the node semver package feels the leading v is valid and therefore we happily stamped the full v17.2.5 out into our package.json files.

Expected Behavior

Now even if such an accidental publish were to happen, the leading v would always be stripped before applying it.

Related Issue(s)

Fixes #

@JamesHenry JamesHenry requested a review from a team as a code owner December 17, 2023 12:09
@JamesHenry JamesHenry requested a review from mandarini December 17, 2023 12:09
Copy link

vercel bot commented Dec 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2023 0:09am

@JamesHenry JamesHenry merged commit 1b464d8 into nrwl:master Dec 18, 2023
2 checks passed
@JamesHenry JamesHenry deleted the version-strip-leading-v branch December 18, 2023 12:59
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants