Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): add overall nx release command #20535

Merged
merged 28 commits into from
Dec 20, 2023

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Dec 1, 2023

Current Behavior

Versioning, changelog generation, and publishing must be done in distinct steps.

Expected Behavior

Versioning, changelog generation, and publishing can be done in the same step by running:
nx release [specifier]

The command will prompt the user for confirmation before publishing if --dry-run is not set. This prompt can be overridden with the --no and --yes flags, or their aliases, -n and -y.

Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Dec 12, 2023 11:33am

@fahslaj fahslaj force-pushed the feat/nx-release-meta-command branch from 74cdca6 to 72b4477 Compare December 1, 2023 17:03
@fahslaj fahslaj marked this pull request as ready for review December 4, 2023 22:29
@fahslaj fahslaj changed the title feat(release): meta command for version and changelog feat(release): meta command for nx release Dec 4, 2023
@JamesHenry
Copy link
Collaborator

Converted to draft until the introductory documentation is added

@JamesHenry
Copy link
Collaborator

Added initial docs (based on plan agreed with @isaacplmann), they are ready for review

@JamesHenry JamesHenry marked this pull request as ready for review December 20, 2023 13:03
@JamesHenry JamesHenry requested a review from a team as a code owner December 20, 2023 13:03
@JamesHenry JamesHenry changed the title feat(release): add nx release command fix(release): add overall nx release command Dec 20, 2023
@JamesHenry JamesHenry enabled auto-merge (squash) December 20, 2023 13:05
Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this as is, but I'll move a lot of the Release section of the nx.json docs into a separate page in a future PR.

@JamesHenry JamesHenry merged commit 82fb2da into nrwl:master Dec 20, 2023
jaysoo pushed a commit that referenced this pull request Dec 22, 2023
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2023
@fahslaj fahslaj deleted the feat/nx-release-meta-command branch January 4, 2024 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants