-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nestjs lib generator pass skipPackageJson flag to js lib generator #20442
fix: nestjs lib generator pass skipPackageJson flag to js lib generator #20442
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f334dfc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
@jaysoo this tiny PR would help us to fix our generator, is there a chance to get this merged in the near future? |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 26636cf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Using the nestjs library generator with skipPackageJson: true adds ts-node to package.json.
Expected Behavior
skipPackageJson: true in nestjs lib generator should not add anything to package.json
Related Issue(s)
Fixes #
Pass the skipPackageJson flag to the js lib generator so that package.json is not adjusted if the flag is set to true in the nest lib generator.