fix(core): formatter should not fail when absolute paths are provided as "--files" #20331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 702258a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
dmitry-stepanenko
force-pushed
the
ds/fix-formatter-absolute-paths
branch
from
e5f0c24 to
8fc501a
Compare
… as "--files" closes nrwl#20272
dmitry-stepanenko
force-pushed
the
ds/fix-formatter-absolute-paths
branch
from
8fc501a to
702258a
Compare
|
@AgentEnder can you please take a look at this one 🙏 |
AgentEnder
approved these changes
Jan 10, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When using absolute paths with
nx format:write --files=.., checks are being applied to all files in the repositoryExpected Behavior
Should only format provided files
Related Issue(s)
Fixes #20272