feat(testing): add migration for moving test target defaults #19993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 25c540e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
force-pushed
the
jest-migration
branch
2 times, most recently
from
59c4ee3 to
452443e
Compare
FrozenPandaz
force-pushed
the
jest-migration
branch
2 times, most recently
from
c9757e5 to
e47b7c0
Compare
FrozenPandaz
changed the title
jaysoo
reviewed
Nov 2, 2023
| export default async function update(tree: Tree) { | ||
| const nxJson = readNxJson(tree); | ||
|
|
||
| // Don't override anything if there are already target defaults for jest |
| )) { | ||
| // If every target in every project does not use the target default anymore, it can be removed. | ||
| if ( | ||
| Object.values(projects).every((p) => |
There was a problem hiding this comment.
Minor: It's a migration so not too worried about maintenance, but I find the long, nested every hard to grok. Would it better to use nested for-loops?
for (const [targetDefaultKey, targetDefault] of Object.entries(
nxJson.targetDefaults
)) {
let isDefaultUsed = false;
for (const p of Object.values(projects)) {
for (const targetName of Object.keys(p.data?.targets ?? {})) {
const defaults = readTargetDefaultsForTarget(
targetName,
nxJson.targetDefaults,
projectMap.get(p.name).targets?.[targetName]?.executor
);
if (defaults === targetDefault) {
isDefaultUsed = true;
break;
}
}
}
if (!isDefaultUsed) {
delete nxJson.targetDefaults[targetDefaultKey];
}
}| if (value.passWithNoTests === jestDefaults.options.passWithNoTests) { | ||
| delete projConfig.targets[targetName].options.passWithNoTests; | ||
| } else { | ||
| projConfig.targets[targetName].options.passWithNoTests ??= false; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Good catch. Now I don't change the value when one was set in target defaults.
FrozenPandaz
force-pushed
the
jest-migration
branch
from
e47b7c0 to
57ac58d
Compare
FrozenPandaz
force-pushed
the
jest-migration
branch
from
57ac58d to
25c540e
Compare
AgentEnder
approved these changes
Nov 2, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
There is no migration for the changes in #19963. New projects will be created without the settings without a
targetDefaultset.Expected Behavior
There is a migration to move the target defaults and options to the target defaults. New projects will still have those settings set. A lot of configuration will be removed from
project.jsonfiles in the process. 🎉Related Issue(s)
Fixes #