feat(core): remove deprecated defaultCollection and npmScope nx.json … #19708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d512081. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
AgentEnder
requested changes
Oct 18, 2023
Comment on lines
+18
to
+26
| delete nxJson['npmScope']; | ||
|
|
||
| updateNxJson(tree, nxJson); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
I think we should just warn. I'll add that
FrozenPandaz
force-pushed
the
rm-deprecated-properties
branch
from
11145dd to
9272090
Compare
FrozenPandaz
force-pushed
the
rm-deprecated-properties
branch
from
9272090 to
d61297b
Compare
FrozenPandaz
force-pushed
the
rm-deprecated-properties
branch
from
d61297b to
d512081
Compare
AgentEnder
approved these changes
Oct 18, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… properties
Current Behavior
defaultCollectionandnpmScopeconfiguration innx.jsonhas been deprecated for over a year.Expected Behavior
defaultCollectionandnpmScopeconfiguration innx.jsonhave been removed.defaultCollectionis no longer necessary because Nx will prompt when there are multiple collections with the same generator.npmScopeis no longer necessary because it is now read from the rootpackage.json.Related Issue(s)
Fixes #