-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nx-dev): video cards formatting #19449
fix(nx-dev): video cards formatting #19449
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4ffc2bb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better, thanks. There's still an issue where the grid doesn't expand the full size, but that's a problem of the grid component/config rather than the video cards themselves. So we might address it separately.
Basically right now it has 4 grid cols, while only 3 items are in the list:
We should change it s.t. it properly fills the entire space
We need to set the various sm, md and lg props accordingly. I think I messed this up when adjusting the grid component for the docs entry page tiles which might have broken some of the defaults.
Tbh 🤔 I think we could even have just the thumbnails without the title & description. Would probably also look better. Might be worth checking in with @ZackDeRose though as he's working on some "video gallery" component to embed YT vids in our docs. |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Fixes video card formatting
Old cards:
New cards: