Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-dev): video cards formatting #19449

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

isaacplmann
Copy link
Collaborator

@isaacplmann isaacplmann commented Oct 4, 2023

Fixes video card formatting

Old cards:
Screenshot 2023-10-04 at 4 02 06 PM

New cards:
Screenshot 2023-10-04 at 4 01 12 PM

@isaacplmann isaacplmann requested a review from a team as a code owner October 4, 2023 19:49
@isaacplmann isaacplmann requested a review from juristr October 4, 2023 19:49
@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Oct 4, 2023 7:55pm

Copy link
Member

@juristr juristr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks. There's still an issue where the grid doesn't expand the full size, but that's a problem of the grid component/config rather than the video cards themselves. So we might address it separately.

Basically right now it has 4 grid cols, while only 3 items are in the list:
image

We should change it s.t. it properly fills the entire space
image

We need to set the various sm, md and lg props accordingly. I think I messed this up when adjusting the grid component for the docs entry page tiles which might have broken some of the defaults.

@isaacplmann isaacplmann merged commit 479d9a5 into nrwl:master Oct 6, 2023
@juristr
Copy link
Member

juristr commented Oct 6, 2023

Tbh 🤔 I think we could even have just the thumbnails without the title & description. Would probably also look better. Might be worth checking in with @ZackDeRose though as he's working on some "video gallery" component to embed YT vids in our docs.

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants