Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): remove leftover code causing duplicated route config when generating a library #19326

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

Generating a library with routing produces some duplicated route configurations.

Expected Behavior

Generating a library with routing should generate the correct code with no duplicated configuration.

Related Issue(s)

Fixes #19012

@leosvelperez leosvelperez requested a review from a team as a code owner September 25, 2023 16:37
@leosvelperez leosvelperez self-assigned this Sep 25, 2023
@leosvelperez leosvelperez requested a review from jaysoo September 25, 2023 16:37
@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Sep 26, 2023 8:10am

@leosvelperez leosvelperez merged commit 8d767ed into nrwl:master Sep 26, 2023
2 checks passed
@leosvelperez leosvelperez deleted the angular/duplicated-route-config branch September 26, 2023 15:19
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoking libraryGenerator from '@nx/angular/generators' may generate duplicate route file references
2 participants