Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): properly throw error when processing lockfile during postins… #18968

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

…tall

Current Behavior

When lockfile parsing fails, it writes an empty cache which gets reused by later project graph calculations.

Expected Behavior

When lockfile parsing fails, no cache is written and the project graph fails.

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested review from meeroslav and a team as code owners September 1, 2023 14:57
@vercel
Copy link

vercel bot commented Sep 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 2:58pm

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) September 1, 2023 15:03
@FrozenPandaz FrozenPandaz merged commit a5a522e into nrwl:master Sep 1, 2023
@FrozenPandaz FrozenPandaz deleted the fix-lock-file-cache branch September 1, 2023 17:13
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants