feat(linter): add option to ignore files based on pattern #18863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jaysoo
force-pushed
the
feat/linter-dep-check-ignore-files
branch
from
a01d6b7 to
e9b9501
Compare
ndcunningham
approved these changes
Aug 28, 2023
meeroslav
approved these changes
Aug 28, 2023
jaysoo
force-pushed
the
feat/linter-dep-check-ignore-files
branch
3 times, most recently
from
cb27631 to
6b6d7e9
Compare
jaysoo
added
the
PR status: do not merge
|
Doing some local testing before merging. |
- Useful for build config files that import dev-only dependencies
jaysoo
force-pushed
the
feat/linter-dep-check-ignore-files
branch
from
6b6d7e9 to
f23b2b0
Compare
jaysoo
removed
the
PR status: do not merge
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
ignoredFilesoption to the@nx/dependency-checksrule. Useful for build config files that import dev-only dependencies.The
@nx/js:libgenerator that adds the checks forpackage.jsonwill also ignore build configuration files such that packges imported in them will not count towards production dependencies.e.g.
vite.config.tsimportsvite, which is not a production dependency so should not be reported as a missing dependency.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #