fix(testing): omit indexHtmlFile option for cy >12.17.0 for ng ct #18839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
barbados-clemens
added
the
scope: testing tools
barbados-clemens
force-pushed
the
fix/cypress-ng-ct-nightly
branch
from
bb4390f to
c663e94
Compare
barbados-clemens
changed the title
Closed
4 tasks
barbados-clemens
force-pushed
the
fix/cypress-ng-ct-nightly
branch
3 times, most recently
from
a0b956c to
0c1f21e
Compare
barbados-clemens
force-pushed
the
fix/cypress-ng-ct-nightly
branch
from
0c1f21e to
75d6bc2
Compare
AgentEnder
approved these changes
Aug 29, 2023
Coly010
approved these changes
Aug 29, 2023
cypress currently reappends the cwd to the absolute path resulting in invalid paths switch to use a relative path based from the cypress config location to the support file but since the file is in the default locaiton it can be omitted for later cypress verions
barbados-clemens
force-pushed
the
fix/cypress-ng-ct-nightly
branch
from
75d6bc2 to
6655b5a
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
nightly cypress e2e tests are failing for angular component testing with invalid paths to the component-index.html
cypress currently reappends the cwd to the absolute path resulting in invalid paths
switch to omitting the indexHtmlFile option when using v12.17.0+ since it's in the default location and cypress knows how to resolve that file already.
Expected Behavior
cypress is able to read the correct path to the component-index.html when using cy v12.16.0 and v12.17.0 +
Related Issue(s)
passes in CI bc CI is using v12.16.0 but locally and in nightly it uses latest
Fixes #18693