fix(webpack): use new watcher for webpack build coordination plugin #18822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coly010
reviewed
Aug 24, 2023
FrozenPandaz
force-pushed
the
fix-webpack-watch
branch
from
b8699bf to
bba305d
Compare
Cammisuli
approved these changes
Aug 24, 2023
jaysoo
reviewed
Aug 25, 2023
| @@ -48,60 +49,77 @@ class BatchCommandRunner { | |||
| return this.process(); | |||
| } | |||
|
|
|||
| async process() { | |||
| private async process() { | |||
There was a problem hiding this comment.
At this point enqueue is just process, can we move the body into enqueue and remove process?
There was a problem hiding this comment.
Github hid it but enqueue also adds projects and files into pending
jaysoo
approved these changes
Aug 25, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The webpack incremental builds build all of the libs once for every file that changes which can be a lot of files when switching branches.
Also, the webpack incremental builds use
chokidarto watch for file changes.Expected Behavior
The webpack incremental builds only build all of the libs once when many files change at once such as when changing branches.
Also, the webpack incremental builds use the logic from the
nx watchcommand and use the daemon file watcher instead of chokidarRelated Issue(s)
Fixes #