Revert "fix(core): nx should not break if packages were not installed…

[FrozenPandaz]

… (#18687)"

This reverts commit 20acfbe.

Current Behavior

There is an issue for pnpm users where the project graph being calculated without node_modules appears to be successful even though the results differ from the project graph which would be calculated when node_modules are not present. The npm nodes are basically not added to the graph and the dependencies are drawn anyways.

1. When a file has a import which doesn't match the package name such as a deep import (import 'dotenv/config'), the file is deemed to have a dependency to npm:dotenv/config when it should actually depend on npm:dotenv.
2. With the new create nodes and create dependencies APIs this ideally shouldn't be possible because all dependencies should be drawn between 2 nodes.

Expected Behavior

There needs to be another solution for this. If the correct graph cannot be produced without node_modules then the creation should fail. If we want the project graph to succeed without node_modules then we need to produce the right project graph without the node_modules.

This command should produce the same correct dependencies:

 pnpm store prune && nx reset && rm -rf node_modules && pnpm i && node -e "JSON.parse(require('fs').readFileSync('node_modules/.cache/nx/file-map.json').toString()).projectFileMap.nx.filter(f => f.file === 'packages/nx/src/adapter/ngcli-adapter.ts').forEach(f => console.log(f))"

Related Issue(s)

Fixes #

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 22, 2023 11:29pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5416138. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• linux nx affected --target=e2e --base=1c058ded808e0c1491169fca5ddc55d5403abc91 --head=5416138e1ddc1945d5b289672dfb468e8c544e14 --parallel=1
• linux nx affected --target=test --base=1c058ded808e0c1491169fca5ddc55d5403abc91 --head=5416138e1ddc1945d5b289672dfb468e8c544e14 --parallel=1
• linux nx affected --target=build --base=1c058ded808e0c1491169fca5ddc55d5403abc91 --head=5416138e1ddc1945d5b289672dfb468e8c544e14 --parallel=3
• linux nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• linux nx affected --target=lint --base=1c058ded808e0c1491169fca5ddc55d5403abc91 --head=5416138e1ddc1945d5b289672dfb468e8c544e14 --parallel=3
• nx-cloud record -- nx format:check --base=1c058ded808e0c1491169fca5ddc55d5403abc91 --head=5416138e1ddc1945d5b289672dfb468e8c544e14
• linux nx documentation --no-dte
• macos nx affected -t e2e-macos --parallel=1 --base=1c058ded808e0c1491169fca5ddc55d5403abc91 --head=5416138e1ddc1945d5b289672dfb468e8c544e14

---

Sent with 💌 from NxCloud.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.