Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): fixes usages of lintProjectGenerator without eslintFilePatterns provided #18741

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

jbean96
Copy link
Contributor

@jbean96 jbean96 commented Aug 21, 2023

Previous change broke usages of the lintProjectGenerator which did not include an eslintFilePatterns array option. This resolves by first checking for the arrays existence before pushing to it

closed #18740

Related Issue(s)

Fixes #18740

@jbean96 jbean96 requested a review from a team as a code owner August 21, 2023 12:11
@jbean96 jbean96 requested a review from JamesHenry August 21, 2023 12:11
@vercel
Copy link

vercel bot commented Aug 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 6:14pm

AgentEnder
AgentEnder previously approved these changes Aug 21, 2023
Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generator is internal and is meant to be used with caution.

We do not guarantee there won't be any breaking changes in the future.

@meeroslav meeroslav self-assigned this Aug 21, 2023
…atterns provided

Previous change broke usages of the lintProjectGenerator which did not include an eslintFilePatterns
array option. This resolves by first checking for the arrays existence before pushing to it

closed nrwl#18740
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using lintProjectGenerator fails without an options.eslintFilePatterns param
3 participants