docs(core): document all/none for rollup external

[toddbaert]

This option now supports "all"/"none". Moreover the change that added this dramatically changes default packaging behavior of nx:rollup, so it should be clearly documented.

If authors don't take action and had "external": [], (the default) tons of dependencies will suddenly be bundled into the distributed module. For me, that caused a bunch of issues. The least we can do is add this doc, so it's clear how to achieve the previous behavior.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 13, 2023 8:32pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7c1e7d4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx affected -t e2e-macos --parallel=1 --base= --head=
• nx affected --target=e2e --base=881067bbd24431e025ecf3ba9e5849a1c824d6b5 --head=7c1e7d4c87e7370c2242d6c00141afc203d2fc47 --parallel=1
• nx affected --target=test --base=881067bbd24431e025ecf3ba9e5849a1c824d6b5 --head=7c1e7d4c87e7370c2242d6c00141afc203d2fc47 --parallel=1
• nx affected --target=build --base=881067bbd24431e025ecf3ba9e5849a1c824d6b5 --head=7c1e7d4c87e7370c2242d6c00141afc203d2fc47 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files depcheck check-codeowners --parallel=1 --no-dte
• nx affected --target=lint --base=881067bbd24431e025ecf3ba9e5849a1c824d6b5 --head=7c1e7d4c87e7370c2242d6c00141afc203d2fc47 --parallel=3
• nx-cloud record -- nx format:check --base=881067bbd24431e025ecf3ba9e5849a1c824d6b5 --head=7c1e7d4c87e7370c2242d6c00141afc203d2fc47
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[toddbaert]

Thanks for merging @mandarini .

IMHO, it's worth trying to highlight this change as much as possible. I totally see why the change was done, and it certainly was a valid fix. Unfortunately, it also changes the default behavior as I described above, and I'm worried it will give lots of people trouble when they upgrade to 16 and nx/rollup.

[mandarini]

Thank you for the feedback @toddbaert ! I'll keep this in mind! :)

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.