-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular): ng-add migration should set default project #12513
Merged
Coly010
merged 2 commits into
nrwl:master
from
Coly010:angular/set-default-on-migration
Oct 11, 2022
Merged
fix(angular): ng-add migration should set default project #12513
Coly010
merged 2 commits into
nrwl:master
from
Coly010:angular/set-default-on-migration
Oct 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Coly010
force-pushed
the
angular/set-default-on-migration
branch
2 times, most recently
from
October 11, 2022 11:33
e849a2f
to
b4a43a7
Compare
Coly010
force-pushed
the
angular/set-default-on-migration
branch
from
October 11, 2022 12:04
b4a43a7
to
2c5064e
Compare
packages/angular/src/generators/ng-add/migrate-from-angular-cli.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/generators/ng-add/migrate-from-angular-cli.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
Coly010
force-pushed
the
angular/set-default-on-migration
branch
from
October 11, 2022 12:26
c3235b1
to
264b582
Compare
leosvelperez
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
FrozenPandaz
pushed a commit
that referenced
this pull request
Oct 11, 2022
* fix(angular): ng-add migration should set default project * fix(angular): add pr suggestions Co-authored-by: Leosvel Pérez Espinosa <[email protected]> Co-authored-by: Leosvel Pérez Espinosa <[email protected]> (cherry picked from commit 66a0864)
FrozenPandaz
pushed a commit
that referenced
this pull request
Oct 11, 2022
* fix(angular): ng-add migration should set default project * fix(angular): add pr suggestions Co-authored-by: Leosvel Pérez Espinosa <[email protected]> Co-authored-by: Leosvel Pérez Espinosa <[email protected]> (cherry picked from commit 66a0864)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Migration doesn't set the default project
Expected Behavior
Migration should set the default project
Related Issue(s)
Fixes #12332