Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Trailing slash in outputs array prevents correct caching #10708

Merged
merged 1 commit into from
Sep 30, 2022
Merged

fix(core): Trailing slash in outputs array prevents correct caching #10708

merged 1 commit into from
Sep 30, 2022

Conversation

danielsharvey
Copy link
Contributor

Fix by removing trailing slash when performing cp -a into cache.

Add test to confirm fix.

Fixes #10549

@nx-cloud
Copy link

nx-cloud bot commented Jun 11, 2022 •
edited by nx-cloud-staging bot
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4960cda. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Jun 11, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Sep 29, 2022 at 3:23PM (UTC)

@danielsharvey danielsharvey mentioned this pull request Jul 30, 2022
Closed
@FrozenPandaz FrozenPandaz self-assigned this Aug 18, 2022
@niklasravnsborg
Copy link
Contributor

Hej @FrozenPandaz @meeroslav, does one of you have the capacity to review this?

meeroslav
meeroslav requested changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@meeroslav meeroslav left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

Left a few comments. Sorry for waiting on the review.

e2e/workspace-core/src/run-commands.test.ts Outdated Show resolved Hide resolved
packages/nx/src/tasks-runner/cache.ts Outdated Show resolved Hide resolved
@meeroslav
Copy link
Contributor

Once the comments are addressed, we should rebase to the latest version to fix those conflicting files.

@meeroslav meeroslav added the scope: core core nx functionality label Sep 29, 2022
danielsharvey
danielsharvey commented Sep 29, 2022
View reviewed changes
Copy link
Contributor Author

@danielsharvey danielsharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments and let me know. I will rebase now.

packages/nx/src/tasks-runner/cache.ts Outdated Show resolved Hide resolved
e2e/workspace-core/src/run-commands.test.ts Outdated Show resolved Hide resolved
@danielsharvey
fix(core): Trailing slash in outputs array prevents correct caching
4960cda 
Fix by removing trailing slash when performing `cp -a` into cache.

Add test to confirm fix.

Resolves nrwl#10549
@danielsharvey danielsharvey force-pushed the fix/10549-trailing-slash-bug branch from 3ea53d9 to 4960cda Compare September 29, 2022 15:19
@danielsharvey
Copy link
Contributor Author

@meeroslav @AgentEnder I've made changes as requested and rebased. Thanks.

meeroslav
meeroslav approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes. Looks good to me!

@meeroslav meeroslav merged commit 2889372 into nrwl:master Sep 30, 2022
FrozenPandaz pushed a commit that referenced this pull request Oct 4, 2022
@danielsharvey @FrozenPandaz
fix(core): remove trailing slash in outputs that prevents correct cac…
c3f853a 
…hing (#10708)

Fix by removing trailing slash when performing `cp -a` into cache.

Add test to confirm fix.

Resolves #10549

(cherry picked from commit 2889372)
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
@danielsharvey danielsharvey deleted the fix/10549-trailing-slash-bug branch April 30, 2023 01:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AgentEnder AgentEnder AgentEnder left review comments

@meeroslav meeroslav meeroslav approved these changes

Assignees

@FrozenPandaz FrozenPandaz

Labels
scope: core core nx functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trailing slash in outputs array prevents correct caching
5 participants
@danielsharvey @niklasravnsborg @meeroslav @AgentEnder @FrozenPandaz