Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(repo): refactored fileutils #10503

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

Phillip9587
Copy link
Contributor

Current Behavior

Fileutil functions are duplicated across the packages.

Expected Behavior

fileutils should not be duplicated

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented May 28, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0bf4ada. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 8, 2022 at 7:33AM (UTC)

@AgentEnder
Copy link
Member

Hey @Phillip9587! Thanks for the contribution 🎉

It looks like there are some conflicts and failing tests. If you take care of those, this should be good to merge. Thanks!

@Phillip9587 Phillip9587 force-pushed the refactor-fileutils branch 2 times, most recently from 3393809 to 62d898f Compare June 8, 2022 06:37
@Phillip9587 Phillip9587 force-pushed the refactor-fileutils branch from 62d898f to 0bf4ada Compare June 8, 2022 07:33
@Phillip9587
Copy link
Contributor Author

@AgentEnder Thanks for your review. Everything should be fine now.

@AgentEnder AgentEnder merged commit b9e623d into nrwl:master Jun 8, 2022
@Phillip9587 Phillip9587 deleted the refactor-fileutils branch September 1, 2022 08:57
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants